Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly transform spreads of arrays with holes #9146

Closed
wants to merge 1 commit into from
Closed

Correctly transform spreads of arrays with holes #9146

wants to merge 1 commit into from

Conversation

phapp88
Copy link
Contributor

@phapp88 phapp88 commented Dec 7, 2018

Q                       A
Fixed Issues? Fixes #8874
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This pull request removes holes from spreads of nested arrays and replaces them with undefined.

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jun 9, 2021
@nicolo-ribaudo
Copy link
Member

I rebased this at #13439. I'm really sorry that this straightforward fix got ignored for years 😓

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hole array spread inside of another array isn't work correctly
2 participants