Fix handling scoped packages in preset-env include/exclude options #9219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
existentialism
commented
Dec 20, 2018
existentialism
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #9182 |
| Patch: Bug Fix? | Y |
| Major: Breaking Change? | N |
| Minor: New Feature? | N |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
existentialism
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9660/ |
existentialism
force-pushed
the
issue9182
branch
from
f0d68ec
to
f123580
Compare
|
We also need to support the |
existentialism
force-pushed
the
issue9182
branch
from
f123580
to
62be744
Compare
|
@nicolo-ribaudo updated! |
| @@ -76,7 +76,7 @@ const validBrowserslistTargets = [ | |||
| ]; | |||
|
|
|||
| export const normalizePluginName = (plugin: string): string => | |||
| plugin.replace(/^babel-plugin-/, ""); | |||
| plugin.replace(/^@?babel[-/](plugin-)?/, ""); | |||
There was a problem hiding this comment.
This also matches things like @babel-plugin-foo, is it intended to keep the RegExp simple?
There was a problem hiding this comment.
Tweaked it to prevent @babel-plugin-foo
nicolo-ribaudo
approved these changes
Dec 26, 2018
hzoo
approved these changes
Dec 26, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.