Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-parser: typescript: add missing bigint keyword #9230

Merged
merged 2 commits into from Dec 22, 2018
Merged

babel-parser: typescript: add missing bigint keyword #9230

merged 2 commits into from Dec 22, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Dec 22, 2018

Q                       A
Fixed Issues? 👎
Patch: Bug Fix? 👍
Major: Breaking Change? 👎
Minor: New Feature? 👎
Tests Added + Pass? 👍
Documentation PR Link
Any Dependency Changes? 👎
License MIT

This PR adds new bigint keyword added in Typescript 3.2.

reference: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html#bigint

@armano2 armano2 changed the title pabel-parser: typescript: add missing bigint keyword babel-parser: typescript: add missing bigint keyword Dec 22, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 22, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9651/

@armano2 armano2 mentioned this pull request Dec 22, 2018
Closed
@existentialism
Copy link
Member

Can you also add it to:

babel/packages/babel-parser/src/types.js

Line 1154 in fdc869c

export type TsKeywordTypeType =

?

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Dec 22, 2018
@armano2
Copy link
Contributor Author

armano2 commented Dec 22, 2018 •
edited

@existentialism suggestion added

nicolo-ribaudo
nicolo-ribaudo approved these changes Dec 22, 2018
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@existentialism existentialism merged commit b5177ce into babel:master Dec 22, 2018
@existentialism
Copy link
Member

@armano2 thanks!

@armano2 armano2 deleted the bigint branch December 22, 2018 23:19
@armano2 armano2 mentioned this pull request Jan 12, 2019
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@armano2 @babel-bot @existentialism @nicolo-ribaudo