Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@babel/types] Moved generators related to babel-types into the babel-types package directory. #9245

Merged
merged 2 commits into from Jan 8, 2019
Merged

[@babel/types] Moved generators related to babel-types into the babel-types package directory. #9245

merged 2 commits into from Jan 8, 2019

Conversation

cameron-martin
Copy link
Contributor

@cameron-martin cameron-martin commented Dec 27, 2018 •
edited

Q                       A
Fixed Issues? Fixes #9239
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? No - no idea how to automatically test this change.
Documentation PR Link
Any Dependency Changes?
License MIT

@cameron-martin
[@babel/types] Moved type definition generators into package directory.
d866a6b 
Fixes babel#9239, but only partially because the generators still import utils from outside the package directory.
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 27, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9665/

@nicolo-ribaudo
Copy link
Member

Can't we also move utils and docs?

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: types labels Dec 27, 2018
@cameron-martin
Copy link
Contributor Author

Ah I didn't notice that the docs generator pertains only to the types. I'll move that too then.

@cameron-martin
Copy link
Contributor Author

@nicolo-ribaudo Do you know what invokes that docs generator?

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 27, 2018 •
edited

It used to be called by make build, but I removed it (#8142). Now it needs to be manually called to update the website, I think.

cc @xtuc Does the website automatically generate @babel/types docs using this script?

@cameron-martin
Moved docs generator and utils into babel-types package directory.
7579f06 
I split utils.js into one file per function to match the style of the current utils that existed in the babel-types scripts directory.
@cameron-martin cameron-martin changed the title [@babel/types] Moved type definition generators into package directory. [@babel/types] Moved generators related to babel-types into the babel-types package directory. Dec 27, 2018
@cameron-martin
Copy link
Contributor Author

cameron-martin commented Dec 27, 2018 •
edited

I've moved the docs generator & utils into babel-types, now I just need to know if there is anything dependent on the docs generator script that needs updating.

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jan 6, 2019
Open
@cameron-martin
Copy link
Contributor Author

Does anything else need to happen before this is merged?

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jan 8, 2019 •
edited

I'm waiting for another review, but I'll merge this PR before the next release.

existentialism
existentialism approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, we need to get the generated types docs back on the website soon (babel/website#1680).

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jan 8, 2019
Open
6 tasks
@nicolo-ribaudo nicolo-ribaudo merged commit 778a61a into babel:master Jan 8, 2019
@nicolo-ribaudo
Copy link
Member

Thank you!

@cameron-martin cameron-martin deleted the bugfix/publishing-types branch January 11, 2019 10:09
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@babel/types wasn't released after being modified
4 participants
@cameron-martin @babel-bot @nicolo-ribaudo @existentialism