Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[private methods] Define private methods before executing initializers #9248

Merged
merged 1 commit into from Jan 3, 2019
Merged

[private methods] Define private methods before executing initializers #9248

merged 1 commit into from Jan 3, 2019

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #9225
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

cc @tim-mc

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Private Methods labels Dec 27, 2018
@nicolo-ribaudo nicolo-ribaudo added this to In progress in Class features via automation Dec 27, 2018
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9669/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9669/

@tjcrowder
Copy link

Seriously fast turn-around, wow. Just tried it on the REPL and it worked a treat. Thanks @nicolo-ribaudo !

@nicolo-ribaudo nicolo-ribaudo merged commit 865eb93 into babel:master Jan 3, 2019
Class features automation moved this from In progress to Done Jan 3, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Private Methods
Projects
No open projects
Class features
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Location of private field initializer should be able to reference private method defined later
4 participants
@nicolo-ribaudo @babel-bot @tjcrowder @existentialism