Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure modifiers are included in TSParameterProperty ranges #9276

Merged
merged 1 commit into from Jan 4, 2019
Merged

Ensure modifiers are included in TSParameterProperty ranges #9276

merged 1 commit into from Jan 4, 2019

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues? Fixes #6679
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Y/Y
Documentation PR Link
Any Dependency Changes?
License MIT

Aligns our location/range info with TypeScript compiler and typescript-eslint-parser.

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Jan 3, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9695/

JamesHenry
JamesHenry approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @existentialism!

@existentialism existentialism merged commit a58893d into master Jan 4, 2019
@existentialism existentialism deleted the issue6679 branch January 4, 2019 16:02
@armano2 armano2 mentioned this pull request Jan 12, 2019
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript: Modifiers not included in range of TSParameterProperty
4 participants
@existentialism @babel-bot @JamesHenry @nicolo-ribaudo