Fix location for typescript type assertions in AST #9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9701/ |
|
I cannot speak for him, but I believe Andy is focusing on some different projects within MS and may not have so much scope to review this just FYI. Again, I am not in a position to represent him, but just wanted to mention it |
nicolo-ribaudo
approved these changes
Jan 6, 2019
existentialism
approved these changes
Jan 6, 2019
armano2
approved these changes
Jan 6, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first character of a type assertion
<was not included in the the range of the nodeTSTypeAssertion.I guess this was just an oversight when adding typescript to babylon.
Can also be seen in astexplorer when hovering the
TSTypeAssertionNode. https://astexplorer.net/#/gist/5fe1eaa61fe443bd75f9b1425bf11e34/89f5b9520e34c199838eb04db9bed0c755226899