Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test262 update #9288

Merged
merged 3 commits into from Jan 7, 2019
Merged

Test262 update #9288

merged 3 commits into from Jan 7, 2019

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Will follow-up this up with a few PRs to fix some spec parsing issues.

@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 6, 2019
@babel-bot
Copy link
Collaborator

babel-bot commented Jan 6, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9707/

@nicolo-ribaudo
Copy link
Member

We should sort alphabetically the whitelist so that it is actually possible to see the real changes.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jan 6, 2019

I think that it should be done by the script that generates the file, otherwise it will get out of order again. It can be done in another PR if you prefer.

@existentialism
Copy link
Member Author

@nicolo-ribaudo done

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@existentialism existentialism merged commit a55382e into master Jan 7, 2019
@existentialism existentialism deleted the test262-update branch January 7, 2019 14:52
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: test262 outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants