New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error if TypeScript class has empty implements #9292
Conversation
existentialism
commented
Jan 7, 2019
•
edited
edited
Q | A |
---|---|
Fixed Issues? | Fixes #9286 |
Patch: Bug Fix? | Y |
Major: Breaking Change? | N |
Minor: New Feature? | N |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9718/ |
Since the same function is used to parse foo<X, Y>()
, maybe we should move the check to tsParseDelimitedList
?
i just checked and looks like error is missing also in interface heritage
interface foo extends {
}
|
1fbe17c
to
04f68ee
Compare
@armano2 Updated to handle interface/extends as well. @nicolo-ribaudo will follow-up with another PR that improves the error message for |