Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emit and builder for TSImportType #9309

Merged
merged 3 commits into from Jan 10, 2019
Merged

Add emit and builder for TSImportType #9309

merged 3 commits into from Jan 10, 2019

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Jan 10, 2019 •
edited

Authors: @existentialism and I

Q                       A
Fixed Issues? Fixes #7749, Closes #7747
Minor: New Feature? 👍
Tests Added + Pass? Yes
Documentation PR Link
License MIT

@hzoo hzoo added PR: New Feature 🚀 A type of pull request used for our changelog categories area: typescript labels Jan 10, 2019
@babel-bot
Copy link
Collaborator

babel-bot commented Jan 10, 2019 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9741/

@hzoo
Copy link
Member Author

hzoo commented Jan 10, 2019

also just pinging as FYI @armano2 @Kovensky @DanielRosenwasser

@armano2
Copy link
Contributor

armano2 commented Jan 10, 2019

in types you should also update TSTypeQuery

babel/packages/babel-types/src/definitions/typescript.js

Line 188 in 060f02a

exprName: validateType("TSEntityName"), 

    exprName: validateType("TSEntityName", "TSImportType"),

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jan 10, 2019 •
edited

(OT)

Authors: @existentialism and I

GitHub supports marking a commit as done by multiple autors 😉

@hzoo
Copy link
Member Author

hzoo commented Jan 10, 2019

Haha good point @nicolo-ribaudo, we talked about it on the stream too

@hzoo hzoo merged commit 4c2f8d9 into master Jan 10, 2019
@existentialism existentialism deleted the ts-import-emit branch January 10, 2019 18:59
@bnjmnt4n bnjmnt4n mentioned this pull request Feb 6, 2019
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@armano2 armano2 armano2 approved these changes

@danez danez Awaiting requested review from danez

@nicolo-ribaudo nicolo-ribaudo Awaiting requested review from nicolo-ribaudo

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript import(...) types TypeScript 2.9 meta-issue
5 participants
@hzoo @babel-bot @armano2 @nicolo-ribaudo @existentialism