Disallow trailing comma after rest #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9744/ |
existentialism
approved these changes
Jan 11, 2019
| @@ -87,6 +89,11 @@ export default class State { | |||
| // TODO | |||
| input: string; | |||
|
|
|||
| // A comma after "...a" is only allowed in spread, but not in rest. | |||
| // Since we parse destructuring expressions ar array/object literals | |||
There was a problem hiding this comment.
Nit: ar -> in (I think?)
There was a problem hiding this comment.
I think that I meant "as"
nicolo-ribaudo
force-pushed
the
rest-comma
branch
from
0c53bc3
to
1c55efa
Compare
|
I'm merging this since another PR I'm working on depends on this PR. |
nicolo-ribaudo
added
PR: Spec Compliance 👓
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2I started by fixing a bug where Babel did not throw for
[...a,]=[], than found that the logic to disallow it was duplicated in a lot of places: so I merged them together and properly usedthis.stateinstead of passing around therefTrailingCommaPos"reference" parameter.NOTE: In the diff it looks like I added code (
312 insertions(+), 262 deletions(-)), but excluding the test folder it is79 insertions(+), 100 deletions(-)