Fix handling newline with TypeScript declare and abstract classes #9328

existentialism · 2019-01-13T22:07:32Z

babel-bot · 2019-01-13T22:09:15Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9790/

nicolo-ribaudo · 2019-01-13T23:03:31Z

Can you also add the check for type aliases? These should be two statements:

type
Foo = string;

existentialism · 2019-01-14T14:20:13Z

@nicolo-ribaudo updated (was going to originally save it for a follow up pr)

packages/babel-parser/test/fixtures/typescript/module-namespace/module-new-line/input.js

Fix handling newline with TypeScript declare and abstract classes

7680fd6

existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Jan 13, 2019

nicolo-ribaudo added the pkg: parser label Jan 13, 2019

types

8159676

existentialism force-pushed the issue9325 branch from a105357 to 8159676 Compare January 14, 2019 03:53

tweak newline checks for interface, module, and namespace too

bea833f

nicolo-ribaudo reviewed Jan 14, 2019

View reviewed changes

packages/babel-parser/test/fixtures/typescript/module-namespace/module-new-line/input.js Outdated Show resolved Hide resolved

update tests

c7548a4

nicolo-ribaudo approved these changes Jan 14, 2019

View reviewed changes

armano2 approved these changes Jan 15, 2019

View reviewed changes

existentialism merged commit aaec2cd into master Jan 15, 2019

existentialism deleted the issue9325 branch January 15, 2019 12:57

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019

Provide feedback