Copy "optional" property when cloning Identifier node #9333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9791/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9789/ |
existentialism
added
PR: Bug Fix 🐛
nicolo-ribaudo
approved these changes
Jan 14, 2019
unconfident
commented
Jan 14, 2019
existentialism
approved these changes
Jan 14, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9331
Copying value of
optionalproperty of "Identifier" nodes when cloning AST nodes means that clone will be more similar to original node and optional parameters will continue to be optional. Very important when used through babel-template.See #9331 to find out how not copying it caused problems