Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range on TypeScript index signature parameters #9335

Merged
merged 1 commit into from Jan 15, 2019
Merged

Fix range on TypeScript index signature parameters #9335

merged 1 commit into from Jan 15, 2019

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues? Fixes #9319
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Y/Y
Documentation PR Link
Any Dependency Changes?
License MIT

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Jan 14, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9792/

armano2
armano2 approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@armano2 armano2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you

@existentialism existentialism merged commit 34c9890 into master Jan 15, 2019
@existentialism existentialism deleted the issue9319 branch January 15, 2019 12:52
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danez danez danez approved these changes

@armano2 armano2 armano2 approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@babel/parser(ts): index signature parameters has invalid range
5 participants
@existentialism @babel-bot @danez @armano2 @nicolo-ribaudo