Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct "this" in static fields #9508

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Use correct "this" in static fields #9508

merged 1 commit into from
Feb 24, 2019

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 13, 2019 •
edited

Q                       A
Fixed Issues? Fixes #5222
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR partially reverts #6158 by @jridgewell

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields labels Feb 13, 2019
@nicolo-ribaudo nicolo-ribaudo added this to In progress in Class features via automation Feb 13, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10088/

danez
danez approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the issue and the added examples, it seems to do the right thing to me.

@tim-mc tim-mc mentioned this pull request Feb 22, 2019
Merged
@nicolo-ribaudo nicolo-ribaudo merged commit 0b01b52 into babel:master Feb 24, 2019
Class features automation moved this from In progress to Done Feb 24, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the static-field-this branch February 24, 2019 07:15
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Mar 6, 2019
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@danez danez danez approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields
Projects
No open projects
Class features
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transform-class-properties: Static arrow functions are bound to undefined rather than the class
4 participants
@nicolo-ribaudo @babel-bot @jridgewell @danez