Make tests spec compliant by avoiding duplicate declarations in input files #9522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
area: tests
PR: Internal 🏠
danez
commented
Feb 16, 2019
| @@ -65,7 +65,7 @@ describe("arrow function conversion", () => { | |||
| _supercall(); | |||
| () => _supercall(); | |||
| `, | |||
| { methodName: "constructor" }, | |||
| { methodName: "constructor", extend: true }, | |||
There was a problem hiding this comment.
I think extend: true was missing here and not left out on purpose, even though all other tests in this file use it correctly.
super call requires the class to extend another class, so this would throw when #9493 gets merged
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10171/ |
danez
commented
Feb 16, 2019
| @@ -1 +0,0 @@ | |||
| function null() { } | |||
There was a problem hiding this comment.
danez
commented
Feb 16, 2019
| @@ -1 +0,0 @@ | |||
| function true() { } | |||
There was a problem hiding this comment.
danez
commented
Feb 16, 2019
| @@ -1 +0,0 @@ | |||
| function false() { } | |||
There was a problem hiding this comment.
danez
commented
Feb 16, 2019
| @@ -1 +0,0 @@ | |||
| function if() { } | |||
There was a problem hiding this comment.
|
You renamed a lot of function declarations: it doesn't really matter, but they can be duplicated, right? |
|
in some cases yes, i just renamed all duplication in tests that were failing |
nicolo-ribaudo
approved these changes
Feb 17, 2019
existentialism
approved these changes
Feb 18, 2019
danez
added this to In progress
in Parser: Spec Compliance, Refactoring and Performance
via automation
Parser: Spec Compliance, Refactoring and Performance
automation
moved this from In progress
to Done
Feb 19, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does NOT change any real code, only test fixtures are change.
This changes make sure there are no duplicate declarations in any of the
input.m?jsfiles. I extracted this from #9493 as it can be already added independently and makes the review of #9493 easier.For reviewing here the important part is that I did not change the meaning of any test by renaming stuff. This is the reason
import type, { imp } from "";was extracted into a separate file as it collides withimport type from "";, but renamingtypeto something else would probably change the meaning.There is some additional fixes see inline comments.