Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flow babel-generator function parantheses #9523

Merged
merged 1 commit into from
Feb 17, 2019
Merged

Fix flow babel-generator function parantheses #9523

merged 1 commit into from
Feb 17, 2019

Conversation

tanhauhau
Copy link
Member

Q                       A
Fixed Issues? Fixes #9514
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10139/

danez
danez reviewed Feb 16, 2019
View reviewed changes
packages/babel-generator/test/fixtures/flow/type-annotations/output.js
@@ -180,7 +180,7 @@ class Array {

}

var x: () => number | () => string = fn;
var x: () => number | (() => string) = fn;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why the first FunctionTypeAnnotation here is not in parentheses? Isn't its parent also union?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because it is () => (number | (() => ... ))

nicolo-ribaudo
nicolo-ribaudo approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it isn't needed to wrap the last function in a chain of | and &, but I think it's better like this.

@danez danez added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator area: flow labels Feb 17, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 5bb1bb0 into babel:master Feb 17, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danez danez danez approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@babel/plugin-syntax-flow returns incompatible Flow code
4 participants
@tanhauhau @babel-bot @danez @nicolo-ribaudo