Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript generator params #9524

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Fix typescript generator params #9524

merged 2 commits into from
Feb 18, 2019

Conversation

tanhauhau
Copy link
Member

Q                       A
Fixed Issues? Fixes #7109
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@tanhauhau tanhauhau force-pushed the tanhauhau/typescript-output-params branch from 73299c2 to 0203dd3 Compare February 17, 2019 00:45
@babel-bot
Copy link
Collaborator

babel-bot commented Feb 17, 2019 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10146/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10145/

@danez danez added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator area: typescript labels Feb 17, 2019
nicolo-ribaudo
nicolo-ribaudo reviewed Feb 17, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the tests are better suited as input/output fixtures?
Apart from that, this PR looks ready to be merged to me.

@tanhauhau
Copy link
Member Author

Maybe the tests are better suited as input/output fixtures?

But seems like when babel parses (number & string)[], it adds TSParenthesizedType around the TSIntersectionType. thus unable to test this edge case of creating the AST without using TSParenthesizedType

@nicolo-ribaudo nicolo-ribaudo merged commit bbb4d7b into babel:master Feb 18, 2019
@tanhauhau tanhauhau deleted the tanhauhau/typescript-output-params branch February 19, 2019 10:23
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danez danez danez approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[babel-generator] doesn't output parens for TS types when needed
4 participants
@tanhauhau @babel-bot @danez @nicolo-ribaudo