Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #9465 #9566

Merged
merged 1 commit into from
Feb 23, 2019
Merged

fix #9465 #9566

merged 1 commit into from
Feb 23, 2019

Conversation

zloirock
Copy link
Member

fix #9465

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10228/

@zloirock zloirock added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: upstream pkg: preset-env labels Feb 22, 2019
@nicolo-ribaudo
Copy link
Member

Shouldn't the test be about an arrow function inside a class property?

@zloirock
Copy link
Member Author

@nicolo-ribaudo it's a simple check that async-to-generator transform works with esmodules target. If it works here, it should work for arrow functions inside classes too - Babel is not Safari -)

@nicolo-ribaudo nicolo-ribaudo merged commit cade33c into master Feb 23, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the fix-9465 branch February 23, 2019 11:47
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danez danez danez approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: upstream outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find private variable @derivedConstructor (Safari iOS 10.3.1)
4 participants
@zloirock @babel-bot @nicolo-ribaudo @danez