Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript parsers missing token check (#9571) #9572

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Fix TypeScript parsers missing token check (#9571) #9572

merged 2 commits into from
Feb 24, 2019

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Feb 24, 2019 •
edited

Q                       A
Fixed Issues? Fixes #9571
Patch: yes
Tests Added + Pass? Yes
Any Dependency Changes? No
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10238/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10238/

nicolo-ribaudo
nicolo-ribaudo approved these changes Feb 24, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 9f34577 into babel:master Feb 24, 2019
@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Feb 24, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danez danez danez approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@babel/parser does not parse non-null members named 'readonly' in TypeScript
5 participants
@elevatebart @babel-bot @danez @nicolo-ribaudo @existentialism