Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@babel/parser] Add "allowUndeclaredExports" option #9864

Merged
merged 1 commit into from Jun 30, 2019
Merged

[@babel/parser] Add "allowUndeclaredExports" option #9864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/babel-parser/src/options.js
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ export type Options = {
allowReturnOutsideFunction: boolean,
allowImportExportEverywhere: boolean,
allowSuperOutsideMethod: boolean,
allowUndeclaredExports: boolean,
plugins: PluginList,
strictMode: ?boolean,
ranges: boolean,
Expand All @@ -41,6 +42,8 @@ export const defaultOptions: Options = {
allowImportExportEverywhere: false,
// TODO
allowSuperOutsideMethod: false,
// When enabled, export statements can reference undeclared variables.
allowUndeclaredExports: false,
// An array of plugins to enable
plugins: [],
// TODO
Expand Down
6 changes: 5 additions & 1 deletion packages/babel-parser/src/parser/statement.js
View file
Open in desktop
Expand Up @@ -49,7 +49,11 @@ export default class StatementParser extends ExpressionParser {

this.parseBlockBody(program, true, true, tt.eof);

if (this.inModule && this.scope.undefinedExports.size > 0) {
if (
this.inModule &&
!this.options.allowUndeclaredExports &&
this.scope.undefinedExports.size > 0
) {
for (const [name] of Array.from(this.scope.undefinedExports)) {
const pos = this.scope.undefinedExports.get(name);
// $FlowIssue
Expand Down
1 change: 1 addition & 0 deletions packages/babel-parser/test/fixtures/core/opts/allowUndeclaredExports/input.js
View file
Open in desktop
@@ -0,0 +1 @@
export { foo };
4 changes: 4 additions & 0 deletions packages/babel-parser/test/fixtures/core/opts/allowUndeclaredExports/options.json
View file
Open in desktop
@@ -0,0 +1,4 @@
{
"sourceType": "module",
"allowUndeclaredExports": true
}
103 changes: 103 additions & 0 deletions packages/babel-parser/test/fixtures/core/opts/allowUndeclaredExports/output.json
View file
Open in desktop
@@ -0,0 +1,103 @@
{
"type": "File",
"start": 0,
"end": 15,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 15
}
},
"program": {
"type": "Program",
"start": 0,
"end": 15,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 15
}
},
"sourceType": "module",
"interpreter": null,
"body": [
{
"type": "ExportNamedDeclaration",
"start": 0,
"end": 15,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 15
}
},
"specifiers": [
{
"type": "ExportSpecifier",
"start": 9,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 12
}
},
"local": {
"type": "Identifier",
"start": 9,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 12
},
"identifierName": "foo"
},
"name": "foo"
},
"exported": {
"type": "Identifier",
"start": 9,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 12
},
"identifierName": "foo"
},
"name": "foo"
}
}
],
"source": null,
"declaration": null
}
],
"directives": []
}
}