Skip to content

Commit

Permalink
add some tests and use indexOf
Browse files Browse the repository at this point in the history
  • Loading branch information
@vigneshshanmugam
vigneshshanmugam committed Feb 16, 2017
1 parent 3686b0d commit 56154cd
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 16 deletions.
8 changes: 5 additions & 3 deletions packages/babel-plugin-minify-builtins/__tests__/__snapshots__/minify-builtins.js.snap
View file
Expand Up @@ -67,10 +67,12 @@ function a() {
}
`;

exports[`minify-builtins should not evaluate if its has side effecty arguments 1`] = `
exports[`minify-builtins should not evaluate if its side effecty 1`] = `
Object {
"_source": "Math.max(foo(), 1);",
"expected": "Math.max(foo(), 1);",
"_source": "Math.max(foo(), 1);
Math.random();",
"expected": "Math.max(foo(), 1);
Math.random();",
}
`;

Expand Down
3 changes: 2 additions & 1 deletion packages/babel-plugin-minify-builtins/__tests__/minify-builtins.js
View file
Expand Up @@ -68,9 +68,10 @@ describe("minify-builtins", () => {
expect({_source: source, expected: transform(source)}).toMatchSnapshot();
});

it("should not evaluate if its has side effecty arguments", () => {
it("should not evaluate if its side effecty", () => {
const source = unpad(`
Math.max(foo(), 1);
Math.random();
`);
expect({_source: source, expected: transform(source)}).toMatchSnapshot();
});
Expand Down
4 changes: 2 additions & 2 deletions packages/babel-plugin-minify-builtins/src/index.js
View file
Expand Up @@ -112,8 +112,8 @@ module.exports = function({ types: t }) {
const { object, property } = memberExpr.node;

if (t.isIdentifier(object) && t.isIdentifier(property)
&& VALID_CALLEES.includes(object.name)
&& !INVALID_METHODS.includes(property.name)) {
&& VALID_CALLEES.indexOf(object.name) >= 0
&& INVALID_METHODS.indexOf(property.name) < 0) {
return true;
}
return false;
Expand Down
20 changes: 10 additions & 10 deletions packages/babel-preset-babili/__tests__/__snapshots__/options-tests.js.snap
View file
Expand Up @@ -11,14 +11,14 @@ Object {
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
],
}
Expand All @@ -42,14 +42,14 @@ Object {
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
],
}
Expand Down Expand Up @@ -85,14 +85,14 @@ Object {
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
],
}
Expand Down Expand Up @@ -138,14 +138,14 @@ Object {
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
],
}
Expand Down Expand Up @@ -191,14 +191,14 @@ Object {
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
],
}
Expand All @@ -220,14 +220,14 @@ Object {
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
],
}
Expand Down Expand Up @@ -263,14 +263,14 @@ Object {
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
],
}
Expand All @@ -289,14 +289,14 @@ Array [
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
]
`;
Expand All @@ -314,14 +314,14 @@ Array [
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
]
`;
Expand All @@ -339,14 +339,14 @@ Array [
"babel-plugin-minify-numeric-literals",
"babel-plugin-minify-replace",
"babel-plugin-minify-simplify",
"babel-plugin-minify-builtins",
"babel-plugin-transform-inline-consecutive-adds",
"babel-plugin-transform-member-expression-literals",
"babel-plugin-transform-property-literals",
"babel-plugin-transform-merge-sibling-variables",
"babel-plugin-transform-minify-booleans",
"babel-plugin-transform-undefined-to-void",
"babel-plugin-transform-regexp-constructors",
"babel-plugin-minify-builtins",
"babel-plugin-transform-remove-undefined",
]
`;

0 comments on commit 56154cd

Please sign in to comment.