Remove folding Array.prototype.concat (fix #577) (#578)

* Remove folding Array.prototype.concat (fix #577) * Add another test
babel · Jun 14, 2017 · 6a14696 · 6a14696
1 parent f8d4f07
commit 6a14696
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/packages/babel-plugin-minify-constant-folding/__tests__/constant-folding-test.js b/packages/babel-plugin-minify-constant-folding/__tests__/constant-folding-test.js
@@ -107,10 +107,8 @@ describe("constant-folding-plugin", () => {
   it("should handle Array methods on array literals", () => {
     const source = unpad(
       `
-      [1, 2, 3].concat([4, 5, 6]);
-      [a, b, c].concat([d, e], f, g, [h]);
-      [1, 2, 3]["concat"]([4, 5, 6]);
       [1, 2, 3].push([4, 5, 6]);
+      [1, 2, 3]["push"]([4, 5, 6]);
 
       [1, 2, 3].join();
       ["a", "b", "c"].join();
@@ -142,9 +140,7 @@ describe("constant-folding-plugin", () => {
     );
     const expected = unpad(
       `
-      [1, 2, 3, 4, 5, 6];
-      [a, b, c, d, e, f, g, h];
-      [1, 2, 3, 4, 5, 6];
+      4;
       4;
 
       "1,2,3";

diff --git a/packages/babel-plugin-minify-constant-folding/src/replacements.js b/packages/babel-plugin-minify-constant-folding/src/replacements.js
@@ -32,16 +32,6 @@ module.exports = ({ types: t }) => {
         }
       },
       calls: {
-        concat(...args) {
-          return t.arrayExpression(
-            this.elements.concat(
-              ...args.map(arg => {
-                if (t.isArrayExpression(arg)) return arg.elements;
-                return arg;
-              })
-            )
-          );
-        },
         join(sep = t.stringLiteral(",")) {
           if (!t.isStringLiteral(sep)) return;
           let bad = false;