Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of quotes from property names #585

Closed
k-dauda opened this issue Jun 15, 2017 · 6 comments
Closed

Fix removal of quotes from property names #585

k-dauda opened this issue Jun 15, 2017 · 6 comments

Comments

@k-dauda
Copy link

k-dauda commented Jun 15, 2017

Quotes on property names are still being stripped in IE in production with v0.1.3 despite this fix: #543

@boopathi
Copy link
Member

Right now the quotes if they can be removed from the property names according to ES5, then it will be removed.

What version of IE are you targeting?

And do you have a sample code snippet (or) the property name which is invalid in IE without quotes?

@k-dauda
Copy link
Author

k-dauda commented Jun 15, 2017

@boopathi IE11 and Edge in production have this problem, an example can be seen in this issue: cibernox/ember-power-select#915

@anhpha
Copy link

anhpha commented Aug 27, 2017

will be fixed?

@j-f1
Copy link
Contributor

j-f1 commented Aug 27, 2017

@k-dauda Are you using the transform-es3-property-literals plugin? This should undo the conversion if you run it after Babili.

@k-dauda
Copy link
Author

k-dauda commented Aug 28, 2017

@j-f1, no I am not using that plugin

@boopathi
Copy link
Member

Fixed in #730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants