Disable property litterals package by default #620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package does not work with ES5
|
related #585 |
|
Going to close this one. We will fix it rather than disabling the entire plugin. There is an option for you to disable the plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm suggesting to disable the
babel-plugin-transform-property-literalsby default as it is not working correctly in ES5.I was intending to write a failing unit test, but it turns out that there is already a test that is demonstrating a bad behaviour
https://github.com/babel/babili/blob/master/packages/babel-plugin-transform-property-literals/__tests__/transform-property-literals-test.js#L39