Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for babel-version <6.14.0 #127

Closed
wants to merge 2 commits into from
Closed

Conversation

boopathi
Copy link
Member

Okay. This time I'm sure it works.

But when we include preset options, I guess it is not possible to add them as well as support this.

/cc @loganfsmyth

Copy link
Member

@kangax kangax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boopathi
Copy link
Member Author

I'm thinking of revisiting after we get somewhere with preset options #162 as when I tried previously, it was impossible to detect and throw this custom error (with a preset function). Also we don't have any complaints about this at all now.

@kangax kangax closed this Nov 3, 2016
@kangax
Copy link
Member

kangax commented Nov 3, 2016

I'll close for now so that it doesn't distract us from other PR's

@boopathi boopathi deleted the version-error-1 branch November 25, 2016 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants