Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keepClassName as separate options (fix #298) #311

Merged
merged 3 commits into from Dec 5, 2016
Merged

add keepClassName as separate options (fix #298) #311

merged 3 commits into from Dec 5, 2016

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Dec 1, 2016 •
edited

Separated the keepFnName and updated the tests.

@boopathi boopathi added the Tag: New Feature Pull Request adding a new feature label Dec 1, 2016
@boopathi
Copy link
Member

boopathi commented Dec 1, 2016 •
edited

Can you add a test in preset-options as well ?

Side note:
You can update the snapshots with the -u flag - jest -u /.../options-test.js

@vigneshshanmugam
Copy link
Member Author

@boopathi done

@boopathi
Copy link
Member

boopathi commented Dec 2, 2016

LGTM.. @kangax thoughts?

@kangax kangax merged commit b8bac37 into babel:master Dec 5, 2016
@vigneshshanmugam vigneshshanmugam deleted the keep-classname branch January 20, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Tag: New Feature Pull Request adding a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vigneshshanmugam @boopathi @kangax