Gulp Babili issue #454
Gulp Babili issue #454
Conversation
vigneshshanmugam
commented
Mar 3, 2017
vigneshshanmugam
commented
- options was not passed properly..
- But still couldn't figure out why the comments are removed for the previous case though..
|
rebase screw up fixing it.. |
|
Think you forked from #395 branch |
|
You can run |
vigneshshanmugam
force-pushed
the
gulp-issue
branch
from
e819eef
to
849d44d
Compare
|
Done :) thanks guys |
| return new Promise((resolve, reject) => { | ||
| const stream = gulpBabili({ | ||
| const stream = gulpBabili({}, { |
There was a problem hiding this comment.
this is the options miss I was talking about @boopathi
| @@ -1,11 +1,12 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`gulp-babili comments should remove all comments when false 1`] = `"foo(),bar(),baz();"`; | |||
| exports[`gulp-babili comments should remove all comments when false 1`] = `"function foo(){}bar();var a=baz();"`; | |||
There was a problem hiding this comment.
converting foo() to function foo() {} is the weirdest thing to get it working
There was a problem hiding this comment.
Yes lol.. Dont even know how its working.. Just want to let you guys know there is something wrong!
There was a problem hiding this comment.
So, when converting multiple statements to sequence expressions, the comments are dropped. Should add a test case that this doesn't affect the surrounding block comments.
There was a problem hiding this comment.
Yes exactly.. add a separate test case?
