Remove jsesc

[boopathi]

• Fix unnecessary escaping in string concatinaion #440, fix Invalid string concatenation breaks Lodash _.template method #413
• Related Escape "</script" when inlining strings #384, Allow for exceptions in string concat inlining #382

[codecov]

Codecov Report

Merging #490 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #490      +/-   ##
=========================================
- Coverage   82.62%   82.6%   -0.02%     
=========================================
  Files          35      35              
  Lines        2630    2627       -3     
  Branches      928     927       -1     
=========================================
- Hits         2173    2170       -3     
  Misses        279     279              
  Partials      178     178

Impacted Files	Coverage Δ
.../babel-plugin-minify-constant-folding/src/index.js	82.53% <ø> (-0.8%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42a9d8...58d3571. Read the comment docs.

[goto-bus-stop]

Hmm, the problem in #413/#440 isn't isScriptContext, but all the other things that jsesc does (like escaping backslashes). isScriptContext was the solution to the earlier problem in #382, where </script> could end up in the output inlined in an HTML <script> tag.

A solution entirely in the constant folding plugin would be to manually replace </script> → <\/script> and <!-- to \x3C!--, which is what the isScriptContext option does

[boopathi]

Yes. The problem is running jsesc twice. Babel generator already passes all String Literals via jsesc. I'll add a PR to babel to pass isScriptContext to the generator- but probably will be added to the current track - 7.0. And remove jsesc from babili and this option after that.

[goto-bus-stop]

Yes but this would still run jsesc twice, wouldn't it?

[boopathi]

Will remove jsesc after babel/babel#5581 .

[boopathi]

Merging this and reopening #382 . #382 will be fixed via an option in babel.

[mathiasbynens]

For context, see #440 (comment). This patch is a part of that solution. 👍

[boopathi]

Yes !! babel/babel#5581 .. That's why I kept #382 open. So we can have an enhancement issue open rather than a bug open - and merged this PR.