Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid transforming side effecty member expression checks[fix #469] #506

Closed
wants to merge 1 commit into from

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Apr 18, 2017

  • this transform happens on simplify as well.. So the issue itself is not resolved.

fix #469

Just keeping it here so that we can remove it from one place and apply this fix.

@codecov
Copy link

codecov bot commented Apr 18, 2017

Codecov Report

Merging #506 into master will decrease coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   82.64%   82.57%   -0.07%     
==========================================
  Files          35       35              
  Lines        2633     2652      +19     
  Branches      924      931       +7     
==========================================
+ Hits         2176     2190      +14     
- Misses        279      282       +3     
- Partials      178      180       +2
Impacted Files Coverage Δ
...bel-plugin-minify-guarded-expressions/src/index.js 70.49% <75%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021eead...184cede. Read the comment docs.

@vigneshshanmugam
Copy link
Member Author

@boopathi Does this still happen? Can we merge or close this since we need this for 1.0 milestone

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Jan 31, 2018
@boopathi boopathi deleted the fix-guard branch May 13, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-plugin-minify-dead-code-elimination: produces wrong code
2 participants