Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deadcode): account for impure paths inside for statements #834

Merged
merged 2 commits into from May 10, 2018
Merged

fix(deadcode): account for impure paths inside for statements #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0f5ffa
fix(deadcode): account for impure paths inside for statements
vigneshshanmugam May 8, 2018
f6b1a9a
add env test
vigneshshanmugam May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/babel-plugin-minify-dead-code-elimination/__tests__/fixtures/loops/actual.js
View file
Open in desktop
Expand Up @@ -19,6 +19,10 @@ for (; true; ) {
for (; false; ) {
baz();
}
for (var j; false; ) {
blah();
}
for (0; false; ) {}

// do_while
do {
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-plugin-minify-dead-code-elimination/__tests__/fixtures/loops/expected.js
View file
Open in desktop
Expand Up @@ -16,6 +16,8 @@ for (;;) {
bar();
}

var j;

// do_while
do {
foo();
Expand Down
7 changes: 6 additions & 1 deletion packages/babel-plugin-minify-dead-code-elimination/src/index.js
View file
Open in desktop
Expand Up @@ -678,7 +678,12 @@ module.exports = ({ types: t, traverse }) => {
if (result.value) {
test.remove();
} else {
path.remove();
const init = path.get("init");
if (init.node && !init.isPure()) {
path.replaceWith(init);
} else {
path.remove();
}
}
}
},
Expand Down
13 changes: 13 additions & 0 deletions packages/babel-preset-minify/__tests__/minify-env-tests.js
View file
Open in desktop
Expand Up @@ -183,4 +183,17 @@ describe("preset along with env", () => {
})();
`
);

thePlugin(
"should fix issue#824 simplify + deadcode",
`
let foo;
while (0) {}
console.log(foo);
`,
`
var foo;
console.log(foo);
`
);
});