Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mangle): handle inferred names for functions #842

Merged
merged 2 commits into from May 14, 2018
Merged

fix(mangle): handle inferred names for functions #842

merged 2 commits into from May 14, 2018

Commits on May 14, 2018

  1. fix(mangle): handle inferred names for functions 

    The t.NOT_LOCAL_BINDING symbol used in plugin-function-name
(https://github.com/babel/babel/blob/bd98041321c60737ddcacd1ad7e056ef6de31879/packages/babel-helper-function-name/src/index.js#L206)
is causing this issue.

This was added in babel/babel#3298

The problem is the binding identifier is NOT registered (skipped) during
crawl and the mangler finds the first safe identifier which ultimately
collides with this name during runtime.

So, we register the binding and don't respect the t.NOT_LOCAL_BINDING.

Fix #829
    @boopathi
    boopathi committed May 14, 2018
    Copy the full SHA
    16d3713 View commit details
    Browse the repository at this point in the history

  2. fix lint errors

    @boopathi
    boopathi committed May 14, 2018
    Copy the full SHA
    7040ac5 View commit details
    Browse the repository at this point in the history