Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel.github.io babili plugin docs #1029

Merged
merged 1 commit into from Dec 5, 2016

Conversation

geordidearns
Copy link
Contributor

Hey @hzoo - Ready for a review - Updated the babili plugin documentation on the github pages website to eliminate duplication of documentation. Also added plugin files which weren't there.

Let me know if you need anything re-named, or changed.

Thanks,
Geordi

package: babel-plugin-minify-simplify
---

{% include package_readme.html from="babili" %}
Copy link
Member

@xtuc xtuc Dec 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add an extra line between the text and the code block, since markdownify behaves differently than GH flavored markdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the changes now. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @existentialism Is this where the actual documentation is, not on this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xtuc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtuc pushed a quick fix: babel/minify#320

---
layout: docs
title: Regexp constructors transform
description: This plugin allows Babel to transform boolean literals into !0 for true and !1 for false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should be This changes RegExp constructors into literals if the RegExp arguments are strings.

@geordidearns geordidearns force-pushed the update-babili-plugin-readme-files branch from 4119e6a to 10ecf11 Compare December 4, 2016 17:30
@geordidearns
Copy link
Contributor Author

@xtuc - Have fixed the description above and squashed into the original commit ^ Thanks

@xtuc
Copy link
Member

xtuc commented Dec 4, 2016

Great, thanks for your work. LGTM 👍

@xtuc xtuc merged commit 4529518 into babel:master Dec 5, 2016
@hzoo
Copy link
Member

hzoo commented Dec 5, 2016

nice stuff @geordidearns! thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants