Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(@babel/parser): Document allowUndeclaredExports option. #2047

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Jun 18, 2019

Documents the changes from babel/babel#9864 implemented by @nicolo-ribaudo.

@benjamn benjamn changed the title docs(@babel/parser) Document allowUndeclaredExports option. docs(@babel/parser): Document allowUndeclaredExports option. Jun 18, 2019
@benjamn benjamn force-pushed the document-babel-parser-allowUndeclaredExports-option branch from 1e1e184 to e3b2617 Compare June 18, 2019 21:08
@netlify
Copy link

netlify bot commented Jun 18, 2019

Deploy preview for babel ready!

Built with commit 1e1e184

https://deploy-preview-2047--babel.netlify.com

docs/parser.md Outdated
@@ -46,6 +46,12 @@ mind. When in doubt, use `.parse()`.
outside of class and object methods. Set this to `true` to accept such
code.

- **allowUndeclaredExports**: By default, exporting an identifier that was
not declared in the current module scope will raise an error. Set this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note that this is the spec behavior?

@netlify
Copy link

netlify bot commented Jun 18, 2019

Deploy preview for babel ready!

Built with commit 17c286e

https://deploy-preview-2047--babel.netlify.com

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jun 25, 2019
3 tasks
@nicolo-ribaudo nicolo-ribaudo merged commit f2eb092 into babel:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants