add builtins assumptions #2283
Merged
add builtins assumptions #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for babel ready! Built without sensitive environment variables with commit be90656 |
nicolo-ribaudo
approved these changes
Jun 25, 2020
|
If this is intended to cover issues like babel/babel#11744 and babel/babel#10807, could you please consider adding the assumption that the code will not have any variables in scope with the same name as builtins. There's nothing spec-incompliant about that and builtins are not modified in such cases, so the current wording misses this assumption. |
Co-authored-by: Brian Ng <bng412@gmail.com>
JLHwung
force-pushed
the
add-builtin-assumption
branch
from
04e2ab0
to
be90656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have mentioned this assumption before
babel/babel#7043 (comment)
babel/babel#11372 (comment)
babel/babel#11744 (comment)
but never state it clearly.