Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc for typescript useDefineForClassFields compiler flag #2390

Merged
merged 3 commits into from Oct 22, 2020

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Oct 8, 2020

Hi,

We recently fixed a bug in @babel/preset-typescript (PR, discussion) to not remove fields defined with definite assignment assertion ! when the flag allowDeclareFields = true

@nicolo-ribaudo noted that I should add to the doc that this flag is equivalent to Typescript's compiler flag useDefineForClassFields so I opened this PR to address that.

I don't have much experience with using docasaurus so for versioned_doc, I just copied and pasted the files from /docs to v7.11.0 folder. Hope that will do.

@netlify
Copy link

netlify bot commented Oct 8, 2020

Deploy preview for babel ready!

Built without sensitive environment variables with commit 62b1824

https://deploy-preview-2390--babel.netlify.app

@existentialism
Copy link
Member

No need to create versioned docs, it'll get generated when we create a new version.

@akphi
Copy link
Contributor Author

akphi commented Oct 8, 2020

@existentialism updated

@JLHwung JLHwung merged commit c40ab31 into babel:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants