Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helper-compilation-targets docs #2484

Merged
merged 5 commits into from Apr 20, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 12, 2021

Drafted a doc on @babel/helper-compilation-targets.

Related: babel/babel#13131

Preview

@netlify
Copy link

netlify bot commented Apr 12, 2021

Deploy preview for babel ready!

Built with commit 17e9ed2

https://deploy-preview-2484--babel.netlify.app

@JLHwung JLHwung force-pushed the add-helper-compilation-targets branch from d3a0668 to 5b748f6 Compare April 12, 2021 16:14
@hzoo
Copy link
Member

hzoo commented Apr 12, 2021

Awesome! Maybe could mention other tools using it or why you would as an integration?

@hzoo
Copy link
Member

hzoo commented Apr 12, 2021

Not the best place to put it, but I think we can make another sidebar section for various helper packages including this one

"Tooling Packages": [
"babel-parser",
"babel-core",
"babel-generator",
"babel-code-frame",
"babel-runtime",
"babel-template",
"babel-traverse",
"babel-types"
]
},

Helper Packages or Babel Helper Packages? another one that people use would be the add import one

@JLHwung
Copy link
Contributor Author

JLHwung commented Apr 13, 2021

Helper Packages or Babel Helper Packages? another one that people use would be the add import one

I am good for "Helper Packages", since it is shorter.

@JLHwung JLHwung force-pushed the add-helper-compilation-targets branch from e085df5 to 64570c6 Compare April 13, 2021 17:46
): Set<string>; // A set of enabled plugins
```

Given a compat data table `list` (i.e. `@babel/compat-data`) and [browser targets](preset-env.md#targets) `targets`, return a set of required plugins.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need a doc for @babel/compat-data later

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, love the examples and good approach for us to continue documenting some of these

Co-authored-by: Henry Zhu <hi@henryzoo.com>
@JLHwung JLHwung merged commit c41d5fb into babel:master Apr 20, 2021
@JLHwung JLHwung deleted the add-helper-compilation-targets branch April 20, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants