Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.18.0] Update docs for importInterop option #2639

Merged
merged 5 commits into from May 19, 2022

Conversation

NickHeiner
Copy link
Contributor

@NickHeiner NickHeiner commented Apr 15, 2022

It looks like the umd and amd plugins also support importInterop in the code, but don't mention it in the docs. Should I just copy/paste the entire importInterop section from the CJS docs? It's not obvious to me that that will be accurate. 😄

babel/babel#14456

@netlify
Copy link

netlify bot commented Apr 15, 2022

Deploy Preview for babel ready!

Name Link
🔨 Latest commit 06c4f18
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/62867cc5e1034700082db22b
😎 Deploy Preview https://deploy-preview-2639--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JLHwung
Copy link
Contributor

JLHwung commented Apr 15, 2022

Should I just copy/paste the entire importInterop section from the CJS docs?

Please. Thank you!

@nicolo-ribaudo
Copy link
Member

Or an alternative we could also only link the importInterop docs, rather than copying them, so that they don't risk getting out of sync.

@NickHeiner
Copy link
Contributor Author

Linking seems preferable to me. 😄 But I'll do whatever y'all chose.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.18.0 milestone May 17, 2022
@nicolo-ribaudo nicolo-ribaudo changed the title Update docs for https://github.com/babel/babel/pull/14456 Update docs for importInterop option May 19, 2022
@nicolo-ribaudo nicolo-ribaudo changed the title Update docs for importInterop option [7.18.0] Update docs for importInterop option May 19, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit 4d23df3 into babel:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants