Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad docs for import attributes #2780

Merged
merged 4 commits into from May 26, 2023

Conversation

nicolo-ribaudo
Copy link
Member

Implementation PR: babel/babel#15536

@nicolo-ribaudo nicolo-ribaudo added this to the 7.22.0 milestone May 8, 2023
@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for babel-next ready!

Name Link
🔨 Latest commit 8561e1a
🔍 Latest deploy log https://app.netlify.com/sites/babel-next/deploys/64708975e69e9a0008bcaebf
😎 Deploy Preview https://deploy-preview-2780--babel-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for babel ready!

Name Link
🔨 Latest commit 8561e1a
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/6470897539bfe00008b418a7
😎 Deploy Preview https://deploy-preview-2780--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


### `deprecatedAssertSyntax`

`boolean`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide the default value here?

@JLHwung
Copy link
Contributor

JLHwung commented May 8, 2023

Since we won't provide a transform for import attributes, can you add the sidebar id to

"TC39 Proposals": [
?

@nicolo-ribaudo nicolo-ribaudo merged commit ac754a6 into babel:main May 26, 2023
4 of 5 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the import-attr-docs branch May 26, 2023 10:28
@nicolo-ribaudo nicolo-ribaudo restored the import-attr-docs branch May 26, 2023 10:28
@nicolo-ribaudo nicolo-ribaudo deleted the import-attr-docs branch May 26, 2023 10:28
@nicolo-ribaudo nicolo-ribaudo restored the import-attr-docs branch May 26, 2023 10:28
@nicolo-ribaudo nicolo-ribaudo deleted the import-attr-docs branch May 26, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants