Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noUninitializedPrivateFieldAccess assumption docs #2865

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo added this to the 7.24.0 milestone Feb 26, 2024
Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for babel-next ready!

Name Link
🔨 Latest commit 012e855
🔍 Latest deploy log https://app.netlify.com/sites/babel-next/deploys/65ddb96726b2650009533d06
😎 Deploy Preview https://deploy-preview-2865--babel-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

return MyClass.#id;
}
}
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without assumption:

class MyClass {
  method() {
    return _id._;
  }
}
var _id = {
  _: 123
};

With assumption:

class MyClass {
  method() {
    return _id;
  }
}
var _id = 123;

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for babel ready!

Name Link
🔨 Latest commit 012e855
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/65ddb9674d1b9e0008afb6ee
😎 Deploy Preview https://deploy-preview-2865--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicolo-ribaudo nicolo-ribaudo changed the title Add noUninitializedPrivateFieldAccess assunption docs Add noUninitializedPrivateFieldAccess assumption docs Feb 26, 2024
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note that this assumption is supported since 7.24.0?

docs/assumptions.md Outdated Show resolved Hide resolved
nicolo-ribaudo and others added 2 commits February 27, 2024 11:27
Co-authored-by: Brian Ng <bng412@gmail.com>
@nicolo-ribaudo nicolo-ribaudo merged commit 17a77fb into babel:main Feb 28, 2024
4 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the docs-noUninitializedPrivateFieldAccess branch February 28, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants