Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for transform-runtime's moduleName option #2867

Merged
merged 3 commits into from Feb 28, 2024
Merged

Add docs for transform-runtime's moduleName option #2867

merged 3 commits into from Feb 28, 2024

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo added this to the 7.24.0 milestone Feb 26, 2024
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Feb 26, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited

✅ Deploy Preview for babel-next ready!

Name Link
🔨 Latest commit fe94db4
🔍 Latest deploy log https://app.netlify.com/sites/babel-next/deploys/65ddbbf7aa9b900008fdf95b
😎 Deploy Preview https://deploy-preview-2867--babel-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited

✅ Deploy Preview for babel ready!

Name Link
🔨 Latest commit fe94db4
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/65ddbbf731994b000800190c
😎 Deploy Preview https://deploy-preview-2867--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JLHwung
JLHwung approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the moduleName section after the helpers option? They are sorted alphabetically.

nicolo-ribaudo and others added 2 commits February 27, 2024 11:29
@nicolo-ribaudo @existentialism
Update docs/plugin-transform-runtime.md
1a14734 
Co-authored-by: Brian Ng <bng412@gmail.com>
@nicolo-ribaudo
Reorder
fe94db4
@nicolo-ribaudo nicolo-ribaudo merged commit a7574cb into babel:main Feb 28, 2024
4 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the docs-runtime-moduleName branch February 28, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@existentialism existentialism existentialism left review comments

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
7.24.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @existentialism @JLHwung @liuxingbaoyu