Support 64-bit builds #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 3, 2016 20:05
Instead of hard-coding 'x86', make bash scripts and the update.bat batch file automatically detect the current Cygwin architecture.
Add and implement the '--64bit' command line argument that performs x86_64 builds.
For the copy of the Babun source in the target repository, instead of always cloning from the Babun GitHub repository, clone it from whichever repository is set as the origin of the local repository used for building. This ensures that any commits not in upstream are included in the build.
Pass the "--no-admin" flag to the Cygwin setup so it doesn't try to run with elevated privileges.
Replace the perl_vendor package in the packages list with its individual components, because the perl_vendor package is obsolete and does not exist on x86_64.
The cygfix plug-in patches certain executables in the target. For now, limit it to x86 so that we don't end up with x86 executables in x86_64 builds.
Instead of keeping a version number in $babun/installed/cygwin, use the actual Cygwin version number obtained from 'uname'.
Use the remote repository specified by the local Babun source when checking for updates. This makes sure that any custom commits are kept when updating. 'cygwin.version' is added to the root directory to check for updated Cygwin. This gives the benefit of limited control over Cygwin updates that's branch-specific; e.g. new Cygwin updates can be tested on the branch first before changing 'cygwin.version' to allow all installations to update.
|
Thanks for the awesome work, darchons! Two tentacles way up. 🐙 Unfortunately for all involved, your pull request has sprouted merge conflicts since you first submitted it several months ago. You've invested an extraordinary amount of volunteer effort into this. I'd hate to see that go to waste. I lack the time to resolve these conflicts myself. Would anyone else be able to chip in? Babun really needs 64-bit support. This pull request is the only practical means of making that happen within the lifetime of the known Universe. It deserves our full attention – and, hopefully, assistance. |
kenjones-cisco
added a commit
to kenjones-cisco/babun
that referenced
this pull request
Apr 20, 2017
Adds all the changes from babun#545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babun is pretty awesome but there have been some requests for a 64-bit build of Babun (e.g. issues #234 and #405). With these patches, I was able to make a 64-bit build of Babun. My test build is available at https://people.mozilla.org/~nchen/babun/babun-1.2.1-x86_64-dist.zip (md5=674087d8432952e4b4f593616c489432 sha1=af2fa88de76159b44497bea66f20a76f8f858c1e). It installs and runs, but I haven't tested updates yet.
Some of these patches are about making a custom build of Babun work (like my 64-bit build), so I think it'd okay if they don't get upstreamed, but I think most of the patches are improvements and are good candidates for upstreaming.