Handle incorrect return type from Octokit paginate plugin

[ericvoshall]

Hey, I just made a Pull Request!

Handle an issue with an incorrect return type from the Octokit paginate plugin. This fixes #12761.

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[github-actions]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/integration	packages/integration	patch	v1.2.2

[benjdlambert]

Is this something to do with the code requiring a later version of octokit than what you have installed or are the types outdated? It would be interesting to know a little more what's going on here.

[benjdlambert]

Let's get this in for now, as I want to get this fixed and shipped for tomorrow at least.

[benjdlambert]

Thanks for this! 🙏

[ericvoshall]

Thanks for the merge!

Is this something to do with the code requiring a later version of octokit than what you have installed or are the types outdated? It would be interesting to know a little more what's going on here.

It's an issue with the types - there's an issue open in the project here for the same thing.

[nodify-at]

@benjdlambert do you plan to release a hotfix for this change or should we use the next version? Our catalog scanning is failing because it can not handle the repositories.

[benjdlambert]

1.5 is planned for next week, so we will release it then. If you need it sooner then feel free to jump on the next release train. Using backstage-cli versions:bump --release next should work 🤞

[mwz]

Hi, any chance this could be released as a patch in the 1.4 series while we wait for 1.5 as it's causing issues in the latest stable release?

[nodify-at]

@mwz I didn't try it but you can force via yarn to use an older version of octokit.

  "resolutions": {
     `"@octokit/rest": "^18.12.0"`
  }

[ericvoshall]

We used patch-package to fix this until the official release comes out.