Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Yarn 3 #13273

Merged
merged 29 commits into from
Aug 31, 2022
Merged

Switch to using Yarn 3 #13273

merged 29 commits into from
Aug 31, 2022

Conversation

Rugvip
Copy link
Member

@Rugvip Rugvip commented Aug 21, 2022

Hey, I just made a Pull Request!

Thanks to the prep work by @webark in #11374 and initial work by @dschwank in #9619 we can now start using Yarn 3. This PR migrates this main repo to use Yarn 3, and adds a migration guide for apps. It does not switch the create-app template to use Yarn 3 since there are some tradeoffs and unknowns with Yarn 3, so I figure we hold off on recommending migration just yet.

A huge benefit of switching to Yarn 3 in this repo is that it'll let us use the workspace: version queries, which will reduce the number of merge conflicts significantly.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added auth area:catalog Related to the Catalog Project Area area:techdocs Related to the TechDocs Project Area documentation Improvements or additions to documentation microsite Changes to backstage.io area:scaffolder Everything and all things related to the scaffolder project area search Things related to Search labels Aug 21, 2022
@Rugvip Rugvip force-pushed the rugvip/yarn3 branch 2 times, most recently from a1b8e61 to 303891e Compare August 22, 2022 08:14
@marcus-crane
Copy link
Contributor

I haven't even started using Yarn 2.x 😅

@webark
Copy link
Contributor

webark commented Aug 23, 2022

We switched to yarn 3 about a month ago and have had success. It's plugin system in nice. I don't think it supports the "zero install" feature, but is a nicer experience than yarn 1.

@webark
Copy link
Contributor

webark commented Aug 23, 2022

Oh. one thing tangentially i ran into was that I tried switching all of our internal dependencies to using the "workspace:*", and it all worked, except lerna doesn't know how to handle that url type yet, and we use lerna during the backend build.

lerna/lerna#2564

Is the relevant lerna issue, and they are actively working on it.

The related issue at the end of that also mentions they are adding pnpm support, which we could add in the future, as a side note

@Rugvip Rugvip marked this pull request as ready for review August 23, 2022 21:18
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

@github-actions

This comment was marked as resolved.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip Rugvip merged commit 6a5bbad into master Aug 31, 2022
@Rugvip Rugvip deleted the rugvip/yarn3 branch August 31, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area area:techdocs Related to the TechDocs Project Area auth documentation Improvements or additions to documentation microsite Changes to backstage.io search Things related to Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants