Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @swc/helpers to ^0.5.0 #17269

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 5, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@swc/helpers (source) ^0.4.7 -> ^0.5.0 age adoption passing confidence

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from a team and backstage-service as code owners April 5, 2023 12:58
@renovate renovate bot requested a review from Rugvip April 5, 2023 12:58
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 5, 2023
Signed-off-by: Renovate Bot <bot@renovateapp.com>
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Apr 5, 2023

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/cli packages/cli patch v0.22.6-next.2

@wesley-pattison
Copy link
Contributor

I am also receiving this error in my own CICD pipeline (Azure DevOps), seems related to a very recent 0.5.0 version pushed in @swc/helpers. Any way for me to solve this without waiting on @backstage/cli ?

@antoniomuso
Copy link
Contributor

Me too; currently it gives me this error: Module not found: Error: Can't resolve '@swc/helpers/_/_define_property'

@wesley-pattison
Copy link
Contributor

wesley-pattison commented Apr 6, 2023

Me too; currently it gives me this error: Module not found: Error: Can't resolve '@swc/helpers/_/_define_property'

This is exactly same error I get :(

If you determine a way to resolve this, please let us know. I tried adding @swc/helpers pinned to 0.4.14 in the root package.json resolutions section, but had no success with that.

@antoniomuso
Copy link
Contributor

Me too; currently it gives me this error: Module not found: Error: Can't resolve '@swc/helpers/_/_define_property'

This is exactly same error I get :(

If you determine a way to resolve this, please let us know. I tried adding @swc/helpers pinned to 0.4.14 in the root package.json resolutions section, but had no success with that.

Currently, this happens to me by regenerating the yarn.lock I don't know what dependency causes the error.

@awanlin
Copy link
Collaborator

awanlin commented Apr 6, 2023

I spent a few hours with this yesterday. As part of our version upgrade process we run yarn upgrade and that seems to have updated something that triggered this same Module not found: Error: Can't resolve '@swc/helpers/_/_define_property' error when we run yarn --cwd packages/backend build. Rolling back the yarn.lock file fixes the issue.

I took some time to try and reproduce this with just the Backstage repo itself but no luck and same with a fresh run of create-app then doing the same upgrade, that worked. So I'm happy to see others running into this as well but sorry that others are having this issue too 😭

@Rugvip just wanted to get this on your radar. I'm going to do some more digging today

@awanlin
Copy link
Collaborator

awanlin commented Apr 6, 2023

Silly me it's clearly this package as the build for this PR is failing the same way: https://github.com/backstage/backstage/actions/runs/4618728081/jobs/8166539640?pr=17269#step:7:18

Signed-off-by: Fredrik AdelΓΆw <freben@gmail.com>
@github-actions github-actions bot added the microsite Changes to backstage.io label Apr 6, 2023
@freben
Copy link
Member

freben commented Apr 6, 2023

Seems that the build works locally if I bump the requirements a bit. Let's see if CI agrees.

@renovate
Copy link
Contributor Author

renovate bot commented Apr 6, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@freben
Copy link
Member

freben commented Apr 6, 2023

For context, the helpers seem to be a new thing and they accidentally messed up the dependency for a short while.

swc-project/swc#7182
swc-project/swc#7206
swc-project/swc#7216

@awanlin
Copy link
Collaborator

awanlin commented Apr 6, 2023

Thanks @freben! I honestly found the SWC repo hard to navigate to figure out what was going on

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Uffizzi Preview deployment-21511 was deleted.

@antoniomuso
Copy link
Contributor

Me too; currently it gives me this error: Module not found: Error: Can't resolve '@swc/helpers/_/_define_property'

This is exactly same error I get :(

If you determine a way to resolve this, please let us know. I tried adding @swc/helpers pinned to 0.4.14 in the root package.json resolutions section, but had no success with that.

I solved putting in resolution: "@swc/core": "1.3.40"

@freben freben merged commit c6e4013 into master Apr 6, 2023
29 checks passed
@freben freben deleted the renovate/swc-helpers-0.x branch April 6, 2023 17:05
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.13.0 release, scheduled for Tue, 18 Apr 2023.

@wesley-pattison
Copy link
Contributor

wesley-pattison commented Apr 6, 2023

Me too; currently it gives me this error: Module not found: Error: Can't resolve '@swc/helpers/_/_define_property'

This is exactly same error I get :(
If you determine a way to resolve this, please let us know. I tried adding @swc/helpers pinned to 0.4.14 in the root package.json resolutions section, but had no success with that.

I solved putting in resolution: "@swc/core": "1.3.40"

Ahhhh, I was close, I tried to resolve the wrong @swc package earlier :D Thanks, this did the trick and my CI is now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file microsite Changes to backstage.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants