Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use linkTarget in ScaffolderField to enable parameter descriptions to open in a new tab as intended #24754

Merged
merged 4 commits into from
May 15, 2024
Merged

Use linkTarget in ScaffolderField to enable parameter descriptions to open in a new tab as intended #24754

merged 4 commits into from
May 15, 2024

Conversation

erik-adsk
Copy link
Contributor

@erik-adsk erik-adsk commented May 13, 2024 •
edited

Hey, I just made a Pull Request!

  • software-templates: Use linkTarget property of MarkdownContent in order to pass "_blank" target to open links (if present) in a new tab

Fixes #24753

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@erik-adsk
fix a bug documented in issue#24753 where markdown descriptions are n…
789aa03 
…ot being opened in a new tab

Signed-off-by: Erik Sjoholm <erik.sjoholm@autodesk.com>
@erik-adsk
Add changeset and api-report
86dc29d 
Signed-off-by: Erik Sjoholm <erik.sjoholm@autodesk.com>
@erik-adsk erik-adsk requested review from a team as code owners May 13, 2024 23:55
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label May 13, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented May 13, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder-react plugins/scaffolder-react patch v1.8.5

benjdlambert
benjdlambert reviewed May 14, 2024
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just a comment about some content in the api-report which I don't think should be there?

plugins/scaffolder-backend/api-report.md Outdated Show resolved Hide resolved
@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@erik-adsk
Remove changes to scaffolder-backend api-report generated by running …
881e49d 
…yarn build:api-reports

Signed-off-by: Erik Sjoholm <erik.sjoholm@autodesk.com>
@erik-adsk @benjdlambert
Update .changeset description to be more succinct
3dca9cb 
Co-authored-by: Ben Lambert <ben@blam.sh>
Signed-off-by: erik-adsk <143032411+erik-adsk@users.noreply.github.com>
@benjdlambert benjdlambert merged commit d31ddb5 into backstage:master May 15, 2024
29 checks passed
@benjdlambert
Copy link
Member

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.28.0 release, scheduled for Tue, 18 Jun 2024.

@github-actions GitHub Actions
Copy link
Contributor

Uffizzi Cluster pr-24754 was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@freben freben Awaiting requested review from freben freben is a code owner automatically assigned from backstage/maintainers

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Links in mardown description content do not open in new tab
2 participants
@erik-adsk @benjdlambert