Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NBS 1.0] Extract service helpers and types to plugin api #24757

Merged
merged 4 commits into from
May 21, 2024
Merged

[NBS 1.0] Extract service helpers and types to plugin api #24757

merged 4 commits into from
May 21, 2024

Conversation

camilaibs
Copy link
Contributor

@camilaibs camilaibs commented May 14, 2024 •
edited

Hey, I just made a Pull Request!

Closes: #24606

In preparation to the new backend system stable release, the isDatabaseConnectionError helper have been moved to the backend-plugin-api package and deprecated from backend-common.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@camilaibs camilaibs requested review from a team as code owners May 14, 2024 07:51
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label May 14, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented May 14, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/backend-common packages/backend-common patch v0.22.0
@backstage/backend-plugin-api packages/backend-plugin-api patch v0.6.18
@backstage/plugin-catalog-backend plugins/catalog-backend patch v1.22.0

@vinzscam vinzscam added the merge-after-release This is a bit too scary to merge until after the next release label May 14, 2024
@camilaibs camilaibs force-pushed the camilaibs/nbs10-extract-service-types-and-helpers branch 4 times, most recently from ffbb8f1 to 0d82fb9 Compare May 15, 2024 07:11
@camilaibs camilaibs requested a review from acierto May 15, 2024 07:11
@github-actions github-actions bot added auth area:techdocs Related to the TechDocs Project Area area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. search Things related to Search area:scaffolder Everything and all things related to the scaffolder project area area:permission Related to the Permission Project Area labels May 15, 2024
@github-actions github-actions bot removed auth area:techdocs Related to the TechDocs Project Area area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. search Things related to Search area:scaffolder Everything and all things related to the scaffolder project area area:permission Related to the Permission Project Area area:discoverability Related to the Discoverability Project Area area:events Related to the Events Project Area labels May 16, 2024
@camilaibs camilaibs changed the title [NBS 1.0] Deprecate legacy service helpers and types [NBS 1.0] Extract service helpers and types to plugin api May 16, 2024
@camilaibs camilaibs removed the merge-after-release This is a bit too scary to merge until after the next release label May 16, 2024
Rugvip
Rugvip requested changes May 17, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Just some changeset nits

.changeset/eighty-kings-dress.md Outdated Show resolved Hide resolved
.changeset/wet-crabs-guess.md Outdated Show resolved Hide resolved
packages/backend-plugin-api/api-report.md Show resolved Hide resolved
camilaibs and others added 2 commits May 17, 2024 14:25
@camilaibs @Rugvip
Update .changeset/wet-crabs-guess.md
c1745b6 
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
@camilaibs @Rugvip
Update .changeset/eighty-kings-dress.md
c09d8df 
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
@camilaibs camilaibs requested a review from Rugvip May 17, 2024 12:26
Rugvip
Rugvip approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@camilaibs camilaibs merged commit c470496 into master May 21, 2024
33 checks passed
@camilaibs camilaibs deleted the camilaibs/nbs10-extract-service-types-and-helpers branch May 21, 2024 13:05
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.28.0 release, scheduled for Tue, 18 Jun 2024.

@github-actions GitHub Actions
Copy link
Contributor

Uffizzi Cluster pr-24757 was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rugvip Rugvip Rugvip approved these changes

@freben freben Awaiting requested review from freben freben is a code owner automatically assigned from backstage/maintainers

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

@alde alde Awaiting requested review from alde alde is a code owner automatically assigned from backstage/catalog-maintainers

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract all service helpers and types from backend-common to the backend-plugin-api
3 participants
@camilaibs @Rugvip @vinzscam