Support both Bitbucket Cloud and Server

[goober]

Hey, I just made a Pull Request!

This pull request will add support for fetching files from Bitbucket Server.

Changes were required in an underlying library so merging this is still blocked by IonicaBizau/git-url-parse#113

Fixes #2735

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)

[benjdlambert]

Hey @goober! Thanks for the contribution and welcome to the community!

Ideally, it would be great if we could wait for your upstream changes to be merged first rather than using your own fork.

There's also some conflicts that could do with fixing too!

Thanks for your work! 🏅

[freben]

cool stuff!

[goober]

@benjdlambert Thanks. Its a fast moving project.. I will rebase against master once again.

It seems that the upstream changes are about to be merged so we can definitely wait with merging this until they have released the new version. I just wanted to make my changes available so people who wants to take it for a spin is able to, and to get some feedback

[goober]

After some further investigation it seems like the Bitbucket cloud api requires the username/appPassword combo for authentication, but also support an oauth2 setup.

However, since the two apis are so different maybe it is better to split them into two readers? Keep the current one and add a new BitbucketServerUrlReader @freben @Rugvip what do you think?

[Rugvip]

@goober configuration-wise I'd like to keep them in one reader, but we could split logic into two helper classes or smth of that sort. I think the GitHub one uses a similar pattern.

Regarding OAuth that may not support our use-case, as this is service to service authentication. Depends on what they implement though.

[bryce-larson]

@goober thank you for add support for BitBucket Server.

I've tested your branch using a TOKEN for auth and it is working as expected.
Finding the apiBaseUrl not well document, but mine the URL I needed was https://<host>/rest/api/latest

[Rugvip]

Looks good, thanks!

[benjdlambert]

@spotify/techdocs-core, could we also get a +1 :)

[JdataNich]

Hi, is there an example of the what the auth or app-config should look like for the bitbucket.org server? thanks

[iamEAP]

Hey @JdataNich, you might get more 👀  eyes on your question if you bring it up in the #support channel in the Backstage discord.