New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fs-extra in scaffolder-backend #6457
Update fs-extra in scaffolder-backend #6457
Conversation
Update fs-extra to 10.0.0 to better handle broken symbolic links. The only breaking changes in the major version upgrade should be this and the requirement of node v12 or higher which backstage also requires. fixes backstage#6456 Signed-off-by: jrusso1020 <jrusso@brex.com>
🦋 Changeset detectedLatest commit: afd9c6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hmmm - really don't want to do this as this was rolled back because of #6416 Can you try and do |
Knew it was only a matter of time before something caught us out like this. The latest version does depend on 10.x that's published to npm FYI. |
Just tried it, looks like it works with this so happy for this to go through. |
Signed-off-by: blam <ben@blam.sh>
Thanks @benjdlambert ! |
@benjdlambert I think |
Hmm not sure. Does it work if you change the target to be the scaffolder backend? I think it's more to do with nested dependencies and yarn getting confused with hoisting or something. Not really sure, really unintuitive error message and a real pain in the ass to debug. |
Hey, I just made a Pull Request!
Update fs-extra to 10.0.0 to better handle broken symbolic links.
The only breaking changes in the major version upgrade should be
this and the requirement of node v12 or higher which backstage
also requires.
fixes #6456
Signed-off-by: jrusso1020 jrusso@brex.com
✔️ Checklist
Signed-off-by
line in the message. (more info)