Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows .yaml extension support #59

Merged
merged 6 commits into from
Oct 28, 2021
Merged

Allows .yaml extension support #59

merged 6 commits into from
Oct 28, 2021

Conversation

diegomarangoni
Copy link
Contributor

Currently using mkdocs.yaml is not supported, it must have the extension .yml.
This PR removes this limitation.

@diegomarangoni diegomarangoni requested a review from a team as a code owner October 12, 2021 09:11
@camilaibs
Copy link
Contributor

Looks great, only one thing, can you take a look at the failed pipeline checks, please?

@diegomarangoni
Copy link
Contributor Author

It's failing because the new mkdocs version does not support python 3.5
how should I proceed?

@camilaibs
Copy link
Contributor

It's failing because the new mkdocs version does not support python 3.5 how should I proceed?

You can use version 1.2.2

@diegomarangoni
Copy link
Contributor Author

It's failing because the new mkdocs version does not support python 3.5 how should I proceed?

You can use version 1.2.2

It also requires python >= 3.6

@camilaibs
Copy link
Contributor

It's failing because the new mkdocs version does not support python 3.5 how should I proceed?

You can use version 1.2.2

It also requires python >= 3.6

Just for more context, I'd like to involve @emmaindal or maybe @OrkoHunter in this topic.
Do you know why we have these version list and would like to hear from you if we lose support for python 3.5 in favor of these changes or any other recommendations to resolve this issue?

@camilaibs
Copy link
Contributor

It's failing because the new mkdocs version does not support python 3.5 how should I proceed?

You can use version 1.2.2

It also requires python >= 3.6

Just for more context, I'd like to involve @emmaindal or maybe @OrkoHunter in this topic. Do you know why we have these version list and would like to hear from you if we lose support for python 3.5 in favor of these changes or any other recommendations to resolve this issue?

Hello @diegomarangoni, we've talked internally, and it's okay to remove pyhton 3.5 from this list since that 3.5 is deprecated and everything continues to work as expected, so you can go ahead and remove 🙂

Thanks, @emmaindal for discussing this internally 🙌🏻

@diegomarangoni
Copy link
Contributor Author

Nice! should I do it in a separate PR? or here is fine?

@camilaibs
Copy link
Contributor

Nice! should I do it in a separate PR? or here is fine?

Here, to keep the context of why we did it. Thank you again!

@iamEAP
Copy link
Member

iamEAP commented Oct 25, 2021

Just to follow-up on this @diegomarangoni: we're good with merging this once you get to removing 3.5 from the supported python versions (I think a README.md update + an update to the GitHub workflow version matrix oughtta do it).

@diegomarangoni
Copy link
Contributor Author

hi @camilaibs, @iamEAP,
I dropped support for python 3.5, however, I can't remove the required github check
should work now :)

iamEAP and others added 3 commits October 28, 2021 10:24
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
@iamEAP
Copy link
Member

iamEAP commented Oct 28, 2021

Thanks again @diegomarangoni!

@iamEAP iamEAP merged commit b142fb0 into backstage:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants