-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows .yaml extension support #59
Conversation
Looks great, only one thing, can you take a look at the failed pipeline checks, please? |
It's failing because the new |
You can use version 1.2.2 |
It also requires python >= 3.6 |
Just for more context, I'd like to involve @emmaindal or maybe @OrkoHunter in this topic. |
Hello @diegomarangoni, we've talked internally, and it's okay to remove pyhton 3.5 from this list since that 3.5 is deprecated and everything continues to work as expected, so you can go ahead and remove 🙂 Thanks, @emmaindal for discussing this internally 🙌🏻 |
Nice! should I do it in a separate PR? or here is fine? |
Here, to keep the context of why we did it. Thank you again! |
Just to follow-up on this @diegomarangoni: we're good with merging this once you get to removing 3.5 from the supported python versions (I think a README.md update + an update to the GitHub workflow version matrix oughtta do it). |
hi @camilaibs, @iamEAP, |
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
Thanks again @diegomarangoni! |
Currently using
mkdocs.yaml
is not supported, it must have the extension.yml
.This PR removes this limitation.